Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"I get up at 7 a.m. every day." fail #25

Open
thaikhac opened this issue Apr 6, 2023 · 1 comment
Open

"I get up at 7 a.m. every day." fail #25

thaikhac opened this issue Apr 6, 2023 · 1 comment

Comments

@thaikhac
Copy link

thaikhac commented Apr 6, 2023

I get up at 7 a.m. every day.
return result ['0'=>'I get up at 7 a.m.', 'every day.']
The returned result is incorrect, this sentence does not need to be split

@scotteuser
Copy link

I think the basic criteria here to handle this in code is to join 2 splits when:

  1. directly after a full stop is a letter a.m. (from your example it seems like this is fine)
  2. if the subsequent word starts with lowercase word, assuming its a continuation of the previous sentence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants