Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trading): amm changes #7010

Merged
merged 11 commits into from
Oct 15, 2024
Merged

feat(trading): amm changes #7010

merged 11 commits into from
Oct 15, 2024

Conversation

mattrussell36
Copy link
Collaborator

Related issues 🔗

Closes #6851

Description ℹ️

  • Fix use of settlement asset symbol when it should be quote
  • Update markets queries to retrieve symbols from metadata
  • Update markets queries to be a discriminating union for market types

Demo 📺

Gif/video/images of new/corrected functionality if applicable

Technical 👨‍🔧

Details of technical implementation that reviewers may need to be aware of, if applicable.

@mattrussell36 mattrussell36 force-pushed the feat/6851-amms-changes branch from c6187a6 to 42621f9 Compare October 15, 2024 20:28
@mattrussell36 mattrussell36 marked this pull request as ready for review October 15, 2024 23:26
@mattrussell36 mattrussell36 requested a review from a team as a code owner October 15, 2024 23:26
Copy link

@mattrussell36 mattrussell36 merged commit 1fb28a1 into develop Oct 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMM first incentive snags
1 participant