Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link in "next-env.d.ts" always links to "pages" version of the docs #68533

Closed
ronanru opened this issue Aug 5, 2024 · 1 comment · Fixed by #68534
Closed

The link in "next-env.d.ts" always links to "pages" version of the docs #68533

ronanru opened this issue Aug 5, 2024 · 1 comment · Fixed by #68534
Labels
bug Issue was opened via the bug report template. create-next-app Related to our CLI tool for quickly starting a new Next.js application. locked

Comments

@ronanru
Copy link
Contributor

ronanru commented Aug 5, 2024

Link to the code that reproduces this issue

https://codesandbox.io/p/devbox/stupefied-wave-go8s7s?file=%2Fnext-env.d.ts

To Reproduce

This is an issue with the create-next-app template.

  1. Create a new next app with app router
  2. The last line in next-env.d.ts is
// see https://nextjs.org/docs/basic-features/typescript for more information.
  1. If you open the link, it's the pages router docs

Current vs. Expected behavior

The link should link to https://nextjs.org/docs/app/building-your-application/configuring/typescript

Provide environment information

Operating System:
  Platform: linux
  Arch: x64
  Version: #1 SMP PREEMPT_DYNAMIC Sat, 03 Aug 2024 17:56:17 +0000
  Available memory (MB): 32018
  Available CPU cores: 12
Binaries:
  Node: 20.16.0
  npm: 10.8.2
  Yarn: 1.22.22
  pnpm: 9.6.0
Relevant Packages:
  next: 15.0.0-canary.102 // Latest available version is detected (15.0.0-canary.102).
  eslint-config-next: N/A
  react: 19.0.0-rc-06d0b89e-20240801
  react-dom: 19.0.0-rc-06d0b89e-20240801
  typescript: 5.5.4
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

create-next-app

Which stage(s) are affected? (Select all that apply)

next dev (local)

Additional context

This is more of a minor annoyance, and not really a bug, but still I think it's worth fixing. Especially because it might confuse new devs.

@ronanru ronanru added the bug Issue was opened via the bug report template. label Aug 5, 2024
@github-actions github-actions bot added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Aug 5, 2024
@samcx samcx closed this as completed in 1948f5b Aug 9, 2024
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
lubieowoce pushed a commit that referenced this issue Aug 30, 2024
…r templates (#68534)

Fixes #68533

A link to docs in `next-dev.d.ts` linked to the pages router docs in app
router templates. This was confusing, because some sections on this page
only work with pages router. This PR fixes that

Backport notes: skipped all templates introduced for `--empty` in #65532
---------

Co-authored-by: Sam Ko <[email protected]>
lubieowoce pushed a commit that referenced this issue Sep 2, 2024
…r templates (#68534)

Fixes #68533

A link to docs in `next-dev.d.ts` linked to the pages router docs in app
router templates. This was confusing, because some sections on this page
only work with pages router. This PR fixes that

Backport notes: skipped all templates introduced for `--empty` in #65532
---------

Co-authored-by: Sam Ko <[email protected]>
lubieowoce pushed a commit that referenced this issue Sep 2, 2024
…r templates (#68534)

Fixes #68533

A link to docs in `next-dev.d.ts` linked to the pages router docs in app
router templates. This was confusing, because some sections on this page
only work with pages router. This PR fixes that

Backport notes: skipped all templates introduced for `--empty` in #65532
---------

Co-authored-by: Sam Ko <[email protected]>
lubieowoce pushed a commit that referenced this issue Sep 2, 2024
…r templates (#68534)

Fixes #68533

A link to docs in `next-dev.d.ts` linked to the pages router docs in app
router templates. This was confusing, because some sections on this page
only work with pages router. This PR fixes that

Backport notes: skipped all templates introduced for `--empty` in #65532
---------

Co-authored-by: Sam Ko <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. create-next-app Related to our CLI tool for quickly starting a new Next.js application. locked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant