-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown profile? #2
Comments
Fixed in 506c02a. I'm releasing new versions of mediasoup and mediasoup-client wiht the new version. |
h264-profile-level-id 1.1.0 released. |
Thank you for the quick fix! We should probably add tests for this, but will come back with a MR including also some TS fixes 🙂 |
There are no tests for the new profile in libwebrtc and I don't really know how it should be tested. Please add tests in a PR if you know. |
Ah, I meant that we just test the return value of the example in the OP, since it's used in Chrome already. |
I don't know which profile and level that new value must return. If you know then don't hesitate to add a new test line in test.js. |
Isn't it profile |
I know absolutely nothing about these values and this library. I just ported it from C++ to JS. I cannot help with how it should behave for new profile values. |
mmm, I've done this: #5 |
First of all, thank you for this lib, it's really useful for our project.
We have a question and improvement proposal:
We use the
RTCRtpReceiver.getCapabilities('video').codecs
in Chrome to detect the browser profiles and we also get this line:It seems that this profile is custom/unknown,
parseProfileLevelId('f4001f')
returnsnull
, any idea where it might come from?The text was updated successfully, but these errors were encountered: