Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown profile? #2

Closed
razvanphp opened this issue Dec 18, 2023 · 9 comments
Closed

Unknown profile? #2

razvanphp opened this issue Dec 18, 2023 · 9 comments

Comments

@razvanphp
Copy link

First of all, thank you for this lib, it's really useful for our project.

We have a question and improvement proposal:
We use the RTCRtpReceiver.getCapabilities('video').codecs in Chrome to detect the browser profiles and we also get this line:

90000  | video/H264 | level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=f4001f

It seems that this profile is custom/unknown, parseProfileLevelId('f4001f') returns null, any idea where it might come from?

@ibc ibc closed this as completed in 506c02a Dec 18, 2023
@ibc
Copy link
Member

ibc commented Dec 18, 2023

Fixed in 506c02a.

I'm releasing new versions of mediasoup and mediasoup-client wiht the new version.

@ibc
Copy link
Member

ibc commented Dec 18, 2023

h264-profile-level-id 1.1.0 released.

@razvanphp
Copy link
Author

Thank you for the quick fix! We should probably add tests for this, but will come back with a MR including also some TS fixes 🙂

@ibc
Copy link
Member

ibc commented Dec 18, 2023

There are no tests for the new profile in libwebrtc and I don't really know how it should be tested. Please add tests in a PR if you know.

@razvanphp
Copy link
Author

Ah, I meant that we just test the return value of the example in the OP, since it's used in Chrome already.

@ibc
Copy link
Member

ibc commented Dec 18, 2023

I don't know which profile and level that new value must return. If you know then don't hesitate to add a new test line in test.js.

@razvanphp
Copy link
Author

Isn't it profile PredictiveHigh444 and level 3.1? Or am I missing something?

@ibc
Copy link
Member

ibc commented Dec 18, 2023

I know absolutely nothing about these values and this library. I just ported it from C++ to JS. I cannot help with how it should behave for new profile values.

@ibc
Copy link
Member

ibc commented Dec 18, 2023

but will come back with a MR including also some TS fixes

mmm, I've done this: #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants