From 8787d317fce6c48cdc90c455069500d3da42fc99 Mon Sep 17 00:00:00 2001 From: Kaleb Bozorgzadeh Date: Wed, 7 Oct 2020 09:23:03 -0600 Subject: [PATCH] Address some comments on readability --- lib/scrub.ex | 2 +- lib/scrub/cip/connection_manager.ex | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/scrub.ex b/lib/scrub.ex index dc60a8b..05eb9bd 100644 --- a/lib/scrub.ex +++ b/lib/scrub.ex @@ -63,7 +63,7 @@ defmodule Scrub do {:ok, _} -> {:error, :no_tag_found} - error -> + {:error, _} = error -> error end end diff --git a/lib/scrub/cip/connection_manager.ex b/lib/scrub/cip/connection_manager.ex index e9e94ea..19fa571 100644 --- a/lib/scrub/cip/connection_manager.ex +++ b/lib/scrub/cip/connection_manager.ex @@ -139,9 +139,8 @@ defmodule Scrub.CIP.ConnectionManager do end request_path_padded = <> - request_path = <<0x91, byte_size(request_path)::usint, request_path_padded::binary>> - <> + <<0x91, byte_size(request_path)::usint, request_path_padded::binary>> end def encode_request_path(request_path) when is_list(request_path) do