From 0efc1e09343389552abab6c4fe80f3cca4888888 Mon Sep 17 00:00:00 2001 From: vgrem Date: Fri, 11 Oct 2024 18:41:52 +0300 Subject: [PATCH] fix linter issues --- examples/sharepoint/listitems/get_deleted.py | 4 +- generator/metadata/SharePoint.xml | 39 +++++++++++++++++-- office365/sharepoint/listitems/listitem.py | 11 ++---- .../tenant/administration/tenant.py | 1 - office365/subscriptions/collection.py | 10 ++--- tests/sharepoint/test_tenant.py | 2 +- 6 files changed, 46 insertions(+), 21 deletions(-) diff --git a/examples/sharepoint/listitems/get_deleted.py b/examples/sharepoint/listitems/get_deleted.py index 99ef0add..1e189954 100644 --- a/examples/sharepoint/listitems/get_deleted.py +++ b/examples/sharepoint/listitems/get_deleted.py @@ -6,8 +6,6 @@ from tests import test_client_credentials, test_team_site_url ctx = ClientContext(test_team_site_url).with_credentials(test_client_credentials) -result = ( - ctx.web.recycle_bin.get().execute_query() -) +result = ctx.web.recycle_bin.get().execute_query() for item in result: print(item.properties) diff --git a/generator/metadata/SharePoint.xml b/generator/metadata/SharePoint.xml index d0565b91..f0ba8a3e 100644 --- a/generator/metadata/SharePoint.xml +++ b/generator/metadata/SharePoint.xml @@ -1073,6 +1073,7 @@ + @@ -10559,6 +10560,9 @@ + + + @@ -10595,6 +10599,12 @@ + + + + + + @@ -10602,10 +10612,17 @@ + + + + + + + @@ -16769,6 +16786,10 @@ + + + + @@ -16977,9 +16998,6 @@ - - - @@ -22262,6 +22280,9 @@ + + + @@ -24324,6 +24345,9 @@ + + + @@ -31612,7 +31636,6 @@ - @@ -31815,6 +31838,7 @@ + @@ -31980,6 +32004,7 @@ + @@ -32039,6 +32064,7 @@ + @@ -33491,6 +33517,7 @@ + @@ -38657,6 +38684,7 @@ + @@ -38862,6 +38890,7 @@ + @@ -39131,6 +39160,7 @@ + @@ -40994,6 +41024,7 @@ + diff --git a/office365/sharepoint/listitems/listitem.py b/office365/sharepoint/listitems/listitem.py index 54a087d3..7943f5ea 100644 --- a/office365/sharepoint/listitems/listitem.py +++ b/office365/sharepoint/listitems/listitem.py @@ -320,9 +320,7 @@ def _after_system_update(result): # type: (ClientResult[ClientValueCollection[ListItemFormUpdateValue]]) -> None has_any_error = any([item.HasException for item in result.value]) if has_any_error: - raise ValueError( - "Update ListItem failed" - ) + raise ValueError("Update ListItem failed") def _system_update(): from office365.sharepoint.fields.user_value import FieldUserValue @@ -335,7 +333,7 @@ def _system_update(): user = self.context.web.site_users.get_by_id(self.get_property(n)) form_values[n[:-2]] = FieldUserValue.from_user(user) else: - form_values[n] = self.get_property(n) + form_values[n] = self.get_property(n) self.validate_update_list_item( form_values=form_values, @@ -343,16 +341,15 @@ def _system_update(): new_document_update=True, ).after_execute(_after_system_update) - def _list_loaded(): if self.parent_list.base_template == 101: - self.ensure_properties(sys_metadata, _system_update) + self.ensure_properties(sys_metadata, _system_update) else: next_qry = ServiceOperationQuery(self, "SystemUpdate") self.context.add_query(next_qry) self.parent_list.ensure_properties(["BaseTemplate"], _list_loaded) - #self.ensure_properties(sys_metadata, _system_update) + # self.ensure_properties(sys_metadata, _system_update) return self def update_overwrite_version(self): diff --git a/office365/sharepoint/tenant/administration/tenant.py b/office365/sharepoint/tenant/administration/tenant.py index 407e53f8..edeba496 100644 --- a/office365/sharepoint/tenant/administration/tenant.py +++ b/office365/sharepoint/tenant/administration/tenant.py @@ -385,7 +385,6 @@ def get_ransomware_events_overview(self): self.context.add_query(qry) return return_type - def get_sp_list_item_count(self, list_name): # type: (str) -> ClientResult[int] """ """ diff --git a/office365/subscriptions/collection.py b/office365/subscriptions/collection.py index 20262a0e..bae72495 100644 --- a/office365/subscriptions/collection.py +++ b/office365/subscriptions/collection.py @@ -39,12 +39,12 @@ def add( The possible values are: v1_0, v1_1, v1_2, v1_3. :param bool include_resource_data: Indicates whether the resource data for the resource that generated the change notification should be included in the payload of the notification. - :param str encryption_certificate: Specifies the public key certificate which contains only the public key - that Microsoft Graph uses to encrypt the resource data it returns to your app. For security, Microsoft - Graph encrypts the resource data returned in a rich notification. You must provide a public encryption - key as part of creating the subscription. + :param str encryption_certificate: Specifies the public key certificate which contains only the public key + that Microsoft Graph uses to encrypt the resource data it returns to your app. For security, Microsoft + Graph encrypts the resource data returned in a rich notification. You must provide a public encryption + key as part of creating the subscription. :param str encryption_certificate_id: Specifies the identifier of the certificate used to encrypt the content - of the change notification. Use this ID to match in each change notification, which certificate to use + of the change notification. Use this ID to match in each change notification, which certificate to use for decryption. :return: Subscription """ diff --git a/tests/sharepoint/test_tenant.py b/tests/sharepoint/test_tenant.py index 43a498ce..98f549db 100644 --- a/tests/sharepoint/test_tenant.py +++ b/tests/sharepoint/test_tenant.py @@ -211,6 +211,6 @@ def test_30_get_cdn_urls(self): self.assertIsNotNone(result.value) # You need a SharePoint Advanced Management license to perform this action - #def test_31_get_ransomware_events_overview(self): + # def test_31_get_ransomware_events_overview(self): # result = self.tenant.get_ransomware_events_overview().execute_query() # self.assertIsNotNone(result.value)