Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incompatible with deck.gl v9.x , react v18/v19 #283

Open
charlieforward9 opened this issue Jan 1, 2025 · 3 comments · May be fixed by #285
Open

[Bug] Incompatible with deck.gl v9.x , react v18/v19 #283

charlieforward9 opened this issue Jan 1, 2025 · 3 comments · May be fixed by #285
Labels
bug Something isn't working

Comments

@charlieforward9
Copy link

charlieforward9 commented Jan 1, 2025

When I run try installing: npm i @hubble.gl/react

npm error Found: [email protected]
npm error node_modules/deck.gl
npm error   deck.gl@"^9.0.35" from the root project
npm error
npm error Could not resolve dependency:
npm error peer deck.gl@"^8.0.0" from @hubble.gl/[email protected]

I have never contributed to a monorepo like this before, so im opening this issue prior to trying to contribute the chore to learn how to do it the right way.

While one is at it, it would be nice to also bump up to React v18 or v19, as I am getting issues with the peer dep being "^16.8.0"

@charlieforward9 charlieforward9 added the bug Something isn't working label Jan 1, 2025
@charlieforward9 charlieforward9 changed the title [Bug] Incompatible with deck.gl v9.x [Bug] Incompatible with deck.gl v9.x , react v18/v19 Jan 1, 2025
@charlieforward9
Copy link
Author

@chrisgervang I tried avoiding this, but am getting some significant errors regarding the versioning of different deps. I would be happy to contribute to the version bump if I can get some initial assistance understanding the flow here in this monorepo. I have reviewed the README and have started messing with the package.json's but seek a bit more insight into the proper way to bump this. (Ive never worked in a monorepo before) Thank you.

@chrisgervang
Copy link
Collaborator

chrisgervang commented Jan 16, 2025

Thanks for your patience while I take a look into this. Upgrading the packages would be done by manually modifying the package.json files, and contributing would follow the same steps as deck.gl's monorepo (see our CONTRIBUTING.md guide). What errors do you see?

@charlieforward9 charlieforward9 linked a pull request Jan 19, 2025 that will close this issue
@charlieforward9
Copy link
Author

@chrisgervang I tried working my way through all the build issues. Please see and review the assoiated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants