chore: bump deps #285
chore: bump deps #285
Conversation
| import {MapRef, StaticMap, StaticMapProps} from 'react-map-gl'; | ||
| import {MapboxLayer} from '@deck.gl/mapbox/typed'; | ||
| import type {DeckProps, MapViewState} from '@deck.gl/core/typed'; | ||
| import {MapboxOverlay as MapboxLayer} from '@deck.gl/mapbox'; |
There was a problem hiding this comment.
Oh, this actually isn't a drop-in replacement and will require some changes to work. http://deck.gl/docs/upgrade-guide#deckglmapbox
There was a problem hiding this comment.
As a temporary fix I believe we can still import MapboxLayer with import MapboxLayer from '@deck.gl/mapbox/mapbox-layer'
There was a problem hiding this comment.
Rather get this out of the way now. Im not getting any type errors, and all instances in the src/ folder implement the same props {id: ..., ...deck} where id is a string and deck is a Deck obj that may have also been changed in v9 to reflect the change. Let me know.
There was a problem hiding this comment.
The API is different in MapboxOverlay. It creates a deck instance rather than getting passed an instance and that inversion would require a bit of refactoring
There was a problem hiding this comment.
I replaced the deck instance with the deck props in 03a2f0f
I see that the link shows that MapboxLayer to MapboxOverlay shows interleaved: true as the replacement. Should the updated API include this?
| "@luma.gl/core": "^9.0.0", | ||
| "@luma.gl/engine": "^9.0.0", |
There was a problem hiding this comment.
Luma 9.1 was released today and refines a lot of the APIs introduced in 9.0 https://luma.gl/docs/whats-new
There was a problem hiding this comment.
Are you suggesting we set hubble 2.0 to target luma 9.1?
| import {MapRef, StaticMap, StaticMapProps} from 'react-map-gl'; | ||
| import {MapboxLayer} from '@deck.gl/mapbox/typed'; | ||
| import type {DeckProps, MapViewState} from '@deck.gl/core/typed'; | ||
| import {MapboxOverlay as MapboxLayer} from '@deck.gl/mapbox'; |
There was a problem hiding this comment.
The API is different in MapboxOverlay. It creates a deck instance rather than getting passed an instance and that inversion would require a bit of refactoring
|
Not all users (e.g. Kepler.gl) are able to upgrade to deck v9 yet, so I'm considering a hubble 1.4 release with support for the latest version of deck v8 and bumping Hubble.gl to 2.0 for deck v9 support. |
My dependent repo uses deck v9, so I'll aim this PR for 2.0. I am happy to do dig into the |
|
@chrisgervang can we get a 2.0-alpha version released from this PR? Not entirely sure how that'd happen given its monorepo configuration? I'd like to start testing with my dependent application without having to wait for this to land, especially if youre trying to ship a 1.4 version first. Thank you. |
|
@chrisgervang what your roadmap for this PR looking like? I've been waiting to see this land before getting back to the side project I've been looking to enhance with this. Anything I can help with? |
|
I'm actively updating all of the examples to use Then I'll be going through the release process of 1.4, which includes updating dependencies in the existing website and publishing a beta (and assuming all is good, immediately graduating to production). Then we can upgrade to deck 9 with this PR, and I think it could make sense to bump to 2.0 at that point. At some point soon I'd like to upgrade the website to use the latest vis.gl docusorus template instead of gatsby since it's a lot less painful to maintain. This can happen in parallel to the releases. |
|
Hey @charlieforward9 you can merge master in, I don't think they'll be many other changes |
|
@chrisgervang Ok, I'll follow your lead. Just keep me in touch and I'll help out. When you said I can merge master in, what do you mean? I do not have merge access. |
|
Oh I just meant I've pushed changes to master that you'll need to merge into your branch here |
Tried bumping the most important (primarily those within the visgl org) dependencies up to their latest versions and fixing the build issues that came along with them.
Closes #283