Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsxt_policy_group member_type policy evolve #1266

Open
llebotlan opened this issue Jul 19, 2024 · 7 comments
Open

nsxt_policy_group member_type policy evolve #1266

llebotlan opened this issue Jul 19, 2024 · 7 comments
Assignees
Labels
bug Bug
Milestone

Comments

@llebotlan
Copy link

Describe the bug

Today, I have Version 4.1.1.0.0.22224312 NSXT which one can filter nsxt_policy_group member_type SegmentPort and Segment. But I tried from terraform :
criteria {
condition {
member_type = "SegmentPort" <====
key = "Tag"
operator = "EQUALS"
value = "vsphere_port|${var.ports[0]}"
}
condition {
member_type = "Segment" <====
key = "Tag"
operator = "EQUALS"
value = "*{var.nsx_tag}|${var.net}"
}
}
I can do this
nsxt

Reproduction steps

  1. write tf file with nsxt_policy_group defined earlier
  2. launch terraform
  3. observe Error :
    Error: Nested conditions must all use the same member_type, but found 'Segment' with 'SegmentPort'

    │ with nsxt_policy_group.networkTag["monitoring_support"],
    │ on 3-nsx.tf line 366, in resource "nsxt_policy_group" "networkTag":
    │ 366: resource "nsxt_policy_group" "networkTag" {
    ...

Expected behavior

Maybe let NSX API reply for you despite of avoiding unsupported configuration

Additional context

No response

@llebotlan llebotlan added the bug Bug label Jul 19, 2024
@annakhm
Copy link
Collaborator

annakhm commented Jul 22, 2024

Thanks @llebotlan, indeed we should remove this validation as NSX allows combinations now

@annakhm annakhm self-assigned this Jul 22, 2024
@salv-orlando
Copy link
Member

Adding this issue to the 3.7.0 milestone after discussing it with @annakhm

@salv-orlando
Copy link
Member

Moving this issue to 3.8.0 due to release timeline constraints.

@gorkemozlu
Copy link

gorkemozlu commented Oct 24, 2024

Moving this issue to 3.8.0 due to release timeline constraints.

Hi @salv-orlando , also following this issue as well, what's the 3.8.0 release timeline ?

For the context, need this for the following:

`
resource "nsxt_policy_group" "test-app-group2" {

display_name = "test-app-group2"

criteria {
    condition {
        key         = "Name"
        member_type = "KubernetesCluster"
        operator    = "EQUALS"
        value       = "domain-c9_xxxxxxx-antrea"
    }
    condition {
        key         = "Name"
        member_type = "KubernetesNamespace"
        operator    = "EQUALS"
        value       = "test-app"
    }
    condition {
        key         = "Name"
        member_type = "KubernetesService"
        operator    = "EQUALS"
        value       = "test-app-service"
    }
}

}
`

@ksamoray
Copy link
Collaborator

Moving this issue to 3.8.0 due to release timeline constraints.

Hi @salv-orlando , also following this issue as well, what's the 3.8.0 release timeline ?

@gorkemozlu release timeline is available here

@gorkemozlu
Copy link

Hi team @salv-orlando @ksamoray , it looks like tomorrow is the release day for 3.8.0, just checking in for this issue, we still need this :)

@salv-orlando salv-orlando modified the milestones: v3.8.0, v3.9.0 Dec 12, 2024
@salv-orlando
Copy link
Member

@gorkemozlu Unfortunately we need to move this to the v3.9.0 as we're close to the 3.8.0 release (which will be moved by a week in any case). This is a relatively complex use case to address with NSX groups.

We will keep it however in our priority list for v3.9.0.
Btw, the issue is assigned to @annakhm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

No branches or pull requests

5 participants