Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Implement LOCK/UNLOCK support #8

Open
zbleness opened this issue Aug 21, 2024 · 3 comments
Open

[Feature Request] Implement LOCK/UNLOCK support #8

zbleness opened this issue Aug 21, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@zbleness
Copy link
Contributor

What is the underlying problem you would like to see solved?

Improve compatibility with terraform

Describe the ideal solution

TVB support the HTTP LOCK and UNLOCK methods directly:
https://developer.hashicorp.com/terraform/language/settings/backends/http#lock_method

Describe a sufficient solution

This is just a developer experience improvement.

@zbleness zbleness added the enhancement New feature or request label Aug 21, 2024
@aekblad
Copy link
Contributor

aekblad commented Oct 9, 2024

Is this a good idea? At the very least, it doesn't seem like it's worth the effort to implement WebDAV on top of FastAPI:

Any resource that supports the LOCK method MUST, at minimum, support the XML request and response formats defined herein.

Source: WebDAV spec, LOCK verb

@zbleness
Copy link
Contributor Author

zbleness commented Oct 9, 2024

Is this a good idea? At the very least, it doesn't seem like it's worth the effort to implement WebDAV on top of FastAPI:

Any resource that supports the LOCK method MUST, at minimum, support the XML request and response formats defined herein.

Source: WebDAV spec, LOCK verb

The goal is to play well with most recent terraform releases and maybe opentao if there is community interest. Full, RFC compliance is in scope here.

@aekblad
Copy link
Contributor

aekblad commented Oct 10, 2024

Is this a good idea? At the very least, it doesn't seem like it's worth the effort to implement WebDAV on top of FastAPI:

Any resource that supports the LOCK method MUST, at minimum, support the XML request and response formats defined herein.

Source: WebDAV spec, LOCK verb

The goal is to play well with most recent terraform releases and maybe opentao if there is community interest. Full, RFC compliance is in scope here.

Right, I was worried about what's required for interoperability changing from under us without notice. After all, considering the specs involved, it wouldn't be a breaking change for clients to suddenly start using an XML request body to pass parameters.

However, I realize now that this only affects parameters. If we just make sure to keep our endpoints free of query parameters we won't have this problem.

@aekblad aekblad changed the title [Feature Request] <title> [Feature Request] Implement LOCK/UNLOCK support Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants