Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt and yum resources are not listed as dependencies #393

Closed
logicminds opened this issue May 7, 2019 · 4 comments
Closed

apt and yum resources are not listed as dependencies #393

logicminds opened this issue May 7, 2019 · 4 comments
Labels
wont-fix This will not be worked on

Comments

@logicminds
Copy link

Puppet 6 removed the apt resource from the core so it needs to be downloaded separately and listed as a dependency. Without these dependencies this modules does not work.

Would likely have to also add yum_repo as a dependency too.

Once the apt resource is added install can continue.

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6
  • Ruby:
  • Distribution: linux-mint
  • Module version: 7.0.0
@juniorsysadmin juniorsysadmin added the wont-fix This will not be worked on label May 9, 2019
@juniorsysadmin
Copy link
Member

apt and probably yum falls under the category of a soft dependency https://puppet.com/docs/puppet/6.0/style_guide.html#dependencies and I am strongly against adding them as a hard dependency as it causes all kinds of usability and maintenance issues longer term.

The README does mention puppetlabs-apt, but perhaps now with the removal of things from core, more needs to be listed there as part of a Pull Request.

@juniorsysadmin juniorsysadmin added the docs Improvements or additions to documentation label May 9, 2019
@dhoppe
Copy link
Member

dhoppe commented May 9, 2019

@juniorsysadmin I agree that these modules should not be defined as hard dependency, but maybe we should add the following code to our modules, because not everyone reads the docs carefully:

if $facts['package_provider'] == 'deb' and !defined('apt') {
  fail('Please provide the module puppetlabs-apt')
} elsif $facts['package_provider'] == 'yum' and !defined('yumrepo_core') {
  fail('Please provide the module puppetlabs-yumrepo_core')
}

@dhoppe
Copy link
Member

dhoppe commented May 9, 2019

On second thought, I would love to see this at puppetlabs-stdlib, because we would not need to change our modules. But I think the list of modules would be endless:

  • puppetlabs-apt
  • puppetlabs-mysql
  • puppetlabs-postgresql
  • puppetlabs-yumrepo_core
  • camtocamp-systemd
  • stahnma-epel
  • ...

@juniorsysadmin
Copy link
Member

juniorsysadmin commented May 9, 2019

Issue #395 created to add docs

@juniorsysadmin juniorsysadmin removed the docs Improvements or additions to documentation label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wont-fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants