Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-box-4] For a multi-line flexbox when is trimming performed? #11398

Open
bfgeek opened this issue Dec 19, 2024 · 0 comments
Open

[css-box-4] For a multi-line flexbox when is trimming performed? #11398

bfgeek opened this issue Dec 19, 2024 · 0 comments
Labels
css-box-4

Comments

@bfgeek
Copy link

bfgeek commented Dec 19, 2024

Flexbox does a bunch of calculations before it knows what line an item will end up on (e.g. computing the hypothetical size).

Margins can affect these calculations - for example:

<!DOCTYPE html>
<div style="display: flex; flex-wrap: wrap; flex-direction: column; margin-trim: inline; width: 10%; border: solid 2px; height: 300px;">
  <div style="width: -webkit-fill-available; width: stretch; aspect-ratio: 1; background: lime; margin-inline: 20px;">1</div>
  <div style="width: -webkit-fill-available; width: stretch; aspect-ratio: 1; background: lime; margin-inline: 20px;">2</div>
  <div style="width: -webkit-fill-available; width: stretch; aspect-ratio: 1; background: lime; margin-inline: 20px;">3</div>
  <div style="width: -webkit-fill-available; width: stretch; aspect-ratio: 1; background: lime; margin-inline: 20px;">4</div>
</div>

Safari currently has hysteresis[1] in its calculation (e.g. resize the browser window for the above example). So ends up in two different states.

For a multi-line flexbox the differing sizes looks bad to me in this example, IMO it'd be better not to consider trimming at this stage of computing the hypothetical, etc. And instead only consider the trim margins after line-breaking, and flexing has been performed.

[1] Using the value of a previous layout in the next layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-box-4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bfgeek