Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREATION_DATE not populated in report info #1532

Closed
karenhanson opened this issue Jul 7, 2023 · 3 comments
Closed

CREATION_DATE not populated in report info #1532

karenhanson opened this issue Jul 7, 2023 · 3 comments
Assignees
Labels
status: has PR The issue is being processed in a pull request type: regression Something that broke

Comments

@karenhanson
Copy link

I noticed while testing that Creation Date is no longer populated in the report. Is this a permanent change? When I looked at the code, I saw this is commented out with a note to fix it in the future, so it looks like there are plans to bring it back?:

// FIXME 2022 - report container info
// long l = container.getTimeEntry(OCFData.containerEntry);
// if (l > 0)
// {
// Date d = new Date(l);
// String formattedDate = new
// SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'").format(d);
// report.info(OCFData.containerEntry, FeatureEnum.CREATION_DATE,
// formattedDate);
// }

@rdeltour
Copy link
Member

rdeltour commented Jul 7, 2023

I saw this is commented out with a note to fix it in the future, so it looks like there are plans to bring it back?:

Oh absolutely yes, thanks for the report. It looks like I missed this one when refactoring the container parsing code. I'm adding it to the next maintenance release.

@rdeltour rdeltour self-assigned this Jul 7, 2023
@rdeltour rdeltour added this to the Next maintenance release milestone Jul 7, 2023
@rdeltour rdeltour added status: accepted Ready to be further processed type: regression Something that broke labels Jul 7, 2023
@karenhanson
Copy link
Author

@rdeltour Sorry to be a nuisance, but do you have a rough date for the next maintenance release? Just asking as I need to make a decision about whether to submit a PR to upgrade to EPUBCheck 5.1.0 in JHOVE or hold it back a bit longer. If it's likely to be more than a few months away I may do the PR now and add the CREATION_DATE field back in when it's available.

@rdeltour
Copy link
Member

@karenhanson sorry for the late answer. The next maintenance release should be published at the end of this month!

@rdeltour rdeltour added status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed labels Dec 23, 2024
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request and removed status: in progress The issue is being implemented by the development team labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: has PR The issue is being processed in a pull request type: regression Something that broke
Projects
None yet
Development

No branches or pull requests

2 participants