Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect language when more than one summary #527

Closed
mattgarrish opened this issue Dec 6, 2024 · 1 comment
Closed

Incorrect language when more than one summary #527

mattgarrish opened this issue Dec 6, 2024 · 1 comment
Labels
a11y-display-techniques-epub Issue with the epub accessibility metadata display techniques a11y-display-techniques-onix Issue with the onix accessibility metadata display techniques

Comments

@mattgarrish
Copy link
Member

The epub algorithm catches the first accessibility summary, but the xpath for the language finds the last instance of any summary or an ancestor with an xml:lang. So when you have two summaries, the first is output but if the second has a different xml:lang, it will be output with the second one's language.

I don't know if you can have more than one summary in an onix record, but if you can, it should be checked there, too.

@mattgarrish mattgarrish added a11y-display-techniques-epub Issue with the epub accessibility metadata display techniques a11y-display-techniques-onix Issue with the onix accessibility metadata display techniques labels Dec 6, 2024
@mattgarrish
Copy link
Member Author

mattgarrish commented Dec 6, 2024

This may be an xpath 1.0 limitation when I look at it. I might have to modify the suggestion I made in #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-display-techniques-epub Issue with the epub accessibility metadata display techniques a11y-display-techniques-onix Issue with the onix accessibility metadata display techniques
Projects
None yet
Development

No branches or pull requests

1 participant