Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: waveterm injecting NODE_ENV into my terminal which cause incorrect behavior in nodejs package managers #1850

Open
1 of 3 tasks
Satont opened this issue Jan 25, 2025 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Satont
Copy link

Satont commented Jan 25, 2025

Current Behavior

Waveterm injecting NODE_ENV, which cause my pnpm install only production deps in my own projects.

Expected Behavior

Shuldn't be injected

Steps To Reproduce

echo $NODE_ENV

Wave Version

v0.10.4

Platform

Linux

OS Version/Distribution

Archc

Architecture

x64

Anything else?

No response

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
@Satont Satont added bug Something isn't working triage Needs triage labels Jan 25, 2025
@Satont Satont changed the title [Bug]: waveterm injecting NODE_ENV into my terminal which cause incorrect behavior in nodejs [Bug]: waveterm injecting NODE_ENV into my terminal which cause incorrect behavior in nodejs package managers Jan 25, 2025
@esimkowitz
Copy link
Member

esimkowitz commented Jan 25, 2025

This should be very easy to fix. In runWaveSrv in emain-wavesrv.ts, delete NODE_ENV from envCopy before the wavesrv process is started.

@esimkowitz esimkowitz added good first issue Good for newcomers and removed triage Needs triage labels Jan 25, 2025
@esimkowitz
Copy link
Member

esimkowitz commented Jan 27, 2025

Hmm I'm not seeing NODE_ENV getting set, what value is it getting set to and what value is it set to in other terminals?

@Satont
Copy link
Author

Satont commented Jan 29, 2025

@esimkowitz

what value is it getting set

production

what value is it set to in other terminals

It does not exists in other terminals.

@esimkowitz
Copy link
Member

What mechanism did you use to install Wave?

@Satont
Copy link
Author

Satont commented Jan 29, 2025

What mechanism did you use to install Wave?

https://aur.archlinux.org/packages/waveterm-bin through yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants