Time conversions are tied to timezone

[troian]

IntToTimeTime for example returns local time. Does it make sense to turn into?

func IntToTimeTime(v int) time.Time {
	return time.Unix(int64(v), 0).UTC()
}

[RichardLindhout]

I think we should output is as it is stored, so no UTC after getting it from database

[RichardLindhout]

The int should be UNIX and unix should be already UTC since it's the definition of unix but it's always hard to work with timezones etc so not 100% sure about this.

[RichardLindhout]

When storing it already converts to UTC: https://golang.org/pkg/time/#Time.Unix

[RichardLindhout]

So I think you're code from pull request was fine 👍

[RichardLindhout]

I think it's a hard problem maybe. In your API it would depend in some api's you wan't to return the local time and in some you don't want that.

[troian]

Thats quite strange though. We send UTC timestamp but IntToTimeTime converts it to local

[RichardLindhout]

Ok hmm strange maybe set the TZ= environment variable. I always have difficulties with timezone with understanding them.

[RichardLindhout]

I think setting TZ= is maybe a good idea.

[RichardLindhout]

If you use it in docker containers be aware that some containers don't include all timestamps. It did cost us quite some time to find that out back then :-D

[RichardLindhout]

If you use alphine I think it was something like this.

FROM alpine:3.11

ARG TZ='Europe/Amsterdam'

ENV DEFAULT_TZ ${TZ}

RUN apk upgrade --update \
  && apk add -U tzdata \
  && cp /usr/share/zoneinfo/${DEFAULT_TZ} /etc/localtime \
  && apk del tzdata \
  && rm -rf \
  /var/cache/apk/*

CMD ["ls"]