time.Time conversion generates boilergql.TimeTimeToTime()

[troian]

		ID:        m.ID,
		StartsAt:  boilergql.TimeTimeToTime(m.StartsAt),
		EndsAt:    boilergql.TimeTimeToTime(m.EndsAt),

expected

		ID:        m.ID,
		StartsAt:  m.StartsAt,
		EndsAt:    m.EndsAt,

[RichardLindhout]

Are both times exactly the same type?

[RichardLindhout]

Based on TimeTimeToTime they are

[RichardLindhout]

Strange, looking into it!

[troian]

Yah, types are equal

[RichardLindhout]

It should skip these as custom convert since type should be the same here
https://github.com/web-ridge/gqlgen-sqlboiler/blob/master/convert.go#L814

Just to be sure I did not know gqglen supported go timestamps when will they be generated?

[RichardLindhout]

So I can test if it's fixed. It generates as Int for me a.t.m. maybe we should change in sqlboiler-graphql-schema too.

[troian]

Thats what I have in gqlgen.yml

models:
  GeoPoint:
    model:
      - github.com/web-ridge/utils-go/boilergql.GeoPoint
  DateTime:
    model:
      - github.com/99designs/gqlgen/graphql.Time

and graphql.schema uses them like

scalar GeoPoint
scalar DateTime

type Type {
    startsAt: DateTime
    endsAt: DateTime
    createdAt: DateTime
    updatedAt: DateTime
}

[troian]

gqlgen supports time.Time https://github.com/99designs/gqlgen/blob/master/graphql/time.go

[RichardLindhout]

Ok, I'm working on createdAt, updatedAt too a.t.m. will hopefully be able to reproduce this bug this evening and release a new version!

[RichardLindhout]

Maybe you can speedup this process I need more types to ignore in input but multiple ignores like this do not work https://github.com/web-ridge/sqlboiler-graphql-schema
--skip-input-fields=organizationId,createdAt,updatedAt

have you used multiple ignores yet?

[troian]

I haven't. Going to try

[RichardLindhout]

I found it

[RichardLindhout]

Needs to be this I'll update documentation for that and going on with the timestamp!

[RichardLindhout]

<-- forgot cli snippet: Needs to be this --skip-input-fields=organizationId --skip-input-fields=createdAt --skip-input-fields=updatedAt

I'm up and running but I need to add some extra changes since timestamps are nullable in database a.t.m.

[RichardLindhout]

Interesting it should return time.Time but it returns *Time which is the root problem

[RichardLindhout]

Root cause discovered adding fix + test to resolve this

[RichardLindhout]

One side effect we need to update this repo with also TimeTime on grapql side. It looks a little strange but it will work with future packages too

[RichardLindhout]

Released https://github.com/web-ridge/gqlgen-sqlboiler/releases

[RichardLindhout]

You also need to update this package since there will be changes to conversion functions
-->
fca24e7

[RichardLindhout]

So updating to

github.com/web-ridge/[email protected]
github.com/web-ridge/[email protected]

Should fix this bug

[troian]

Thats with the latest release. Time.TimeToMods

	queryMods = append(queryMods, Time.TimeToMods(m.StartsAt, models.AppointmentParticipantColumns.StartsAt)...)
	queryMods = append(queryMods, Time.TimeToMods(m.EndsAt, models.AppointmentParticipantColumns.EndsAt)...)

[RichardLindhout]

Oh my bad.. will fix this.

You have TimeFilter in your schema added then or not?

It will become TimeDotTimeToMods

[RichardLindhout]

Sorry I ment: https://github.com/web-ridge/gqlgen-sqlboiler/releases

[troian]

TimeDotTimeToMods not generated

	queryMods = append(queryMods, TimeDotTimeToMods(m.StartsAt, models.AppointmentParticipantColumns.StartsAt)...)
	queryMods = append(queryMods, TimeDotTimeToMods(m.EndsAt, models.AppointmentParticipantColumns.EndsAt)...)

[RichardLindhout]

Please add TimeDotTimeToMods add it as a filter_custom.go in your helpers package like this we need to do more work to support all gqlgen scalars and/or custom scalars + enums in filtering.

It need some more polishing and I don't think I have time this month but will invest more next month in new features. I'm not sure this will be first but I think also in improving merging or overriding functions and adding support for multiple schema.graphql so you can opt-out for some schema's not sure yet.

We want to support this so I created some issues in both repositories to improve the custom scalars
web-ridge/sqlboiler-graphql-schema#7
web-ridge/gqlgen-sqlboiler#28

[RichardLindhout]

Like this it should work, let me know if it does not.

[RichardLindhout]

filter_custom.go so it will not be overridden when you convert again ;)

[RichardLindhout]

Closing in favor of the issues
web-ridge/sqlboiler-graphql-schema#7
web-ridge/gqlgen-sqlboiler#28