You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So if we really want to restrict the upload here we need to make sure it only happens for avatar uploads which will be hard for async uploads. This is the same problem we'd have in #49
Otherwise we just get rid of this and consider it out of scope for the plugin.
The text was updated successfully, but these errors were encountered:
Good catch! As we already discussed: This plugin was branched out of a larger plugin. There it was meant to restrict all uploads. And yes, I really want to leave this one in. Photographers uploading 30MB avatars should not be allowed.
Oh now that I looked into this some more actually it affects all uploads, but only for the Browser Uploader. When using the Multi-Uploader (plupload) it doesn't do anything ever because it is limited to the screen-bases of 'profile', 'user-edit', 'media', 'upload' which don't include the async-upload endpoint for plupload based uploads.
kraftner
changed the title
AvatarMIMELimitService limits the mime types for all uploads
AvatarMIMELimitService limits mime types for all uploads, but only for the browser-uploader
Nov 22, 2016
I'm not sure how that came to be. Maybe first it was restricted to only the profile page and later was extended to make the multi-uploader work not considering that it now affects all uploads.
So if we really want to restrict the upload here we need to make sure it only happens for avatar uploads which will be hard for async uploads. This is the same problem we'd have in #49
Otherwise we just get rid of this and consider it out of scope for the plugin.
The text was updated successfully, but these errors were encountered: