Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hard-code width and height for stroked-text.png #148

Closed
miketaylr opened this issue Jun 2, 2021 · 2 comments
Closed

hard-code width and height for stroked-text.png #148

miketaylr opened this issue Jun 2, 2021 · 2 comments
Assignees
@miketaylr

Comments

@miketaylr
Copy link
Member

make deploy is failing because the bikeshed API can't autodetect the dimensions of an image that isn't on its server:

https://github.com/tabatkins/bikeshed/blob/c8d499fca18e4e6d53d229fd08ea78612fe51449/bikeshed/unsortedJunk.py#L1737-L1743

So let's just add that in the HTML.
@miketaylr miketaylr self-assigned this Jun 2, 2021
@miketaylr
Copy link
Member Author

See whatwg/whatwg.org#368

miketaylr added a commit that referenced this issue Jun 2, 2021
@miketaylr
Issue #148 - Declare img width and height using attributes, not inlin…
96e0585 
…e style
miketaylr added a commit that referenced this issue Jun 2, 2021
@miketaylr
Issue #148 - Declare img width and height using attributes, not inlin…
4e7181d 
…e style (#149)
@miketaylr
Copy link
Member Author

This is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miketaylr