Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystemWritableFileStream write, seek and truncate description methods are not calling out the case of writable being locked #167

Open
youennf opened this issue Dec 19, 2024 · 1 comment

Comments

@youennf
Copy link

youennf commented Dec 19, 2024

What is the issue with the File System Standard?

The spec currently says to acquire writer before writing.
Given acquiring the writer can throw, this should trigger a promise rejection as per my webIDL understanding.
This was not immediately clear from reading the spec so I wonder whether the spec should mention this somehow.

@annevk
Copy link
Member

annevk commented Dec 19, 2024

I think the non-normative description (aimed at web developers) should definitely mention it can be rejected.

The normative description I'm less clear on. As per https://infra.spec.whatwg.org/#algorithm-control-flow modern practice is to not state something can rethrow, but I do remember @domenic not being entirely comfortable with relying on the Web IDL layer for wrapping a thrown exception into a rejected promise return value. I don't think we ever settled on guidance for it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants