Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reuse and SPDX identifier for automatic license compliance check #21

Open
romangg opened this issue Apr 16, 2020 · 4 comments
Open
Labels

Comments

@romangg
Copy link
Member

romangg commented Apr 16, 2020

In GitLab by @ognarb on Apr 16, 2020, 09:49

Currently, KWinFT and Wrapland don't have any licensing compliance checks. I propose using reuse and a small ci job to check for compliance like I did here: https://invent.kde.org/websites/aether-sass/-/blob/master/.gitlab-ci.yml.

This is already done in KWayland. See https://phabricator.kde.org/D28058 and https://phabricator.kde.org/T11550.

@romangg
Copy link
Member Author

romangg commented Apr 16, 2020

Yes, SPDX is a Linux Foundation standard and reuse also seems to be managed well, so it's a good idea to make use of it.

Actually I looked into this when the patch for KWayland landed. One could use Andreas' script for that but I didn't yet find the time for it.

Since we just talked via PM about it and you said you wanna take a look at it I'm gonna assign you the task. Thank you Carl!

@romangg
Copy link
Member Author

romangg commented Apr 16, 2020

In GitLab by @ognarb on Apr 16, 2020, 23:59

I looked a bit more and it won't be possible to have a licensing compliance test.

Some files don't have a correct SPDX license: src/client/protocols/kwinft-output-management-unstable-v1.xml

so reuse lint will always give errors :(

@romangg
Copy link
Member Author

romangg commented Apr 16, 2020

All xml protocol files or only that one? What would need to change in that file?

@romangg
Copy link
Member Author

romangg commented Apr 16, 2020

The one from KWayland this is based on is this btw: https://cgit.kde.org/kwayland.git/tree/src/client/protocols/output-management.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant