Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ios_check_beta_deps validate Swift Package Manager dependencies as well #604

Open
mokagio opened this issue Oct 21, 2024 · 0 comments

Comments

@mokagio
Copy link
Contributor

mokagio commented Oct 21, 2024

I looked for mentions of this necessity elsewhere but couldn't find any. I'm surprised this hasn't been tracked yet so I guess I just haven't searched well enough. If that's the case, we can close this and add a link. Otherwise...

As we progressively move from CocoaPods to SwiftPM as the dependency manager for our apps, we ought to update our tooling accordingly. In particular, ios_check_beta_deps should list Swift packages that point to non-stable versions in the same way it lists Pods.

This should be a matter of parsing the Package.resolved JSON looking for entries pointing to branches (for which we also ought to have a dedicated Dangermattic check to prevent this, Automattic/dangermattic#85) or commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant