Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: clear core_updater.lock when update is forced? #102

Open
stevegrunwell opened this issue Dec 30, 2018 · 1 comment
Open

Proposal: clear core_updater.lock when update is forced? #102

stevegrunwell opened this issue Dec 30, 2018 · 1 comment

Comments

@stevegrunwell
Copy link
Contributor

I wanted to run this past the maintainers before preparing a pull request:

When running wp core update --force, the process will still abort if another update had been attempted but failed (for example, if the core_updater.lock option was left behind after a failed update). Would it make sense for --force to explicitly clear any locks that might exist, or might this be better served by a new option (e.g. --ignore-lock)?

@schlessera
Copy link
Member

Right now, the help already provides a solution to this by explaining the problem and providing a separate command as a solution:

  If you see "Error: Another update is currently in progress.", you may
  need to run `wp option delete core_updater.lock` after verifying another
  update isn't actually running.

I'm not sure having --force remove the lock automatically (and potentially corrupting the install because an update was indeed in progress) is an improvement...

Maybe we can make the above text appear when you actually hit the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants