String literal input value is trimming whitespace

[mattjohnsonpint]

If I have an operation with a string literal input value that has leading or trailing whitespace, such as:

query {
    test(s: "  abcd  ")
}

... the string gets trimmed to just "abcd" when the operation is parsed.

If instead I pass as a variable, then the string is not trimmed.

According to the GraphQL Spec:

... White space and other otherwise-ignored characters are significant within a string value. ...

Thus I would expect to never have the string input trimmed of whitespace.

I believe this is happening because lexer.readSingleLineString is designed to seek out whitespace and exclude it from the string. IMHO it should not.

graphql-go-tools/v2/pkg/lexer/lexer.go

Lines 387 to 431 in 6526186

	func (l *Lexer) readSingleLineString(tok *token.Token) {
	tok.Keyword = keyword.STRING
	tok.SetStart(l.input.InputPosition, l.input.TextPosition)
	tok.TextPosition.CharStart -= 1
	escaped := false
	whitespaceCount := 0
	reachedFirstNonWhitespace := false
	leadingWhitespaceToken := 0
	for {
	next := l.readRune()
	switch next {
	case runes.SPACE, runes.TAB:
	escaped = false
	whitespaceCount++
	case runes.EOF:
	tok.SetEnd(l.input.InputPosition, l.input.TextPosition)
	tok.Literal.Start += uint32(leadingWhitespaceToken)
	tok.Literal.End -= uint32(whitespaceCount)
	return
	case runes.QUOTE, runes.CARRIAGERETURN, runes.LINETERMINATOR:
	if escaped {
	escaped = !escaped
	continue
	}
	tok.SetEnd(l.input.InputPosition-1, l.input.TextPosition)
	tok.Literal.Start += uint32(leadingWhitespaceToken)
	tok.Literal.End -= uint32(whitespaceCount)
	return
	case runes.BACKSLASH:
	escaped = !escaped
	whitespaceCount = 0
	default:
	if !reachedFirstNonWhitespace {
	reachedFirstNonWhitespace = true
	leadingWhitespaceToken = whitespaceCount
	}
	escaped = false
	whitespaceCount = 0
	}
	}

Thanks.

[jensneuse]

From a first glance it looks like you're right.

[StarpTech]

@devsergiy please take a look.

[mmaxim2710]

Faced the same issue in my project. An interesting observation: if you substitute values not directly, but through query variables, then spaces in strings are not cut off