Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noise Reduction plugin does not remove speaker/headphone output from microphone input #2092

Closed
syphoxy opened this issue Jan 25, 2023 · 3 comments

Comments

@syphoxy
Copy link

syphoxy commented Jan 25, 2023

EasyEffects Version

6.3.0

What package are you using?

NixOS

Distribution

NixOS 22.11

Describe the bug

Noise Reduction module does not remove speaker output from microphone. As far as I can tell, this module should be similar to what NoiseTorch does and NoiseTorch does subtract speaker/headphone output from the microphone.

Expected Behavior

No response

Debug Log

No response

Additional Information

No response

@wwmm
Copy link
Owner

wwmm commented Jan 25, 2023

Noise Reduction module does not remove speaker output from microphone.

Noise removers do not no this. This is the echo canceller task.

NoiseTorch does subtract speaker/headphone output from the microphone.

Probably because it is enabling the server built-in echo canceller. As NoiseTorch does not have to manage an effects pipeline it can make use of it. Unfortunately in EasyEffects we have to provide our own solution for echo cancellation. But as you can see at #951 it has some limitations. I hope to be able to improve it in the future.

@wwmm wwmm closed this as completed Jan 25, 2023
@syphoxy
Copy link
Author

syphoxy commented Jan 25, 2023

I tried using the Echo Canceller task but it didn't do the job either. is there documentation on how to use it?

@wwmm
Copy link
Owner

wwmm commented Jan 25, 2023

I tried using the Echo Canceller task but it didn't do the job either. is there documentation on how to use it?

Besides the few things said by the Speex library developers https://www.speex.org/docs/manual/speex-manual/node7.html#SECTION00740000000000000000 I am not aware of more explanations about the echo canceller frame size and filter length parameters. But based on the discussion at #951 the main factor in this library performance seems to be the microphone signal level. When it is too strong it fails miserably. I have to see if there is something I can do to improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants