automake fails with sourceforce release tarball

[umlaeute]

1. visit https://github.com/x42/xjadeo
2. notice that it links to the "official" homepage http://xjadeo.sf.net/
3. on the sf page go to downloads
4. scroll down to get the download to the source tarball http://sourceforge.net/projects/xjadeo/files/xjadeo/v0.8.14/xjadeo-0.8.14.tar.gz/download
5. download it
6. extract the sources
7. run autoreconf -fiv

$ autoreconf -fiv
[...]
configure.ac:443: error: required file 'src/qt-gui/Makefile.in' not found
configure.ac:443: error: required file 'src/qt-gui/qjadeo.pro.in' not found
[...]

(I'm running autoreconf, as the autogen.sh mentioned in the README is missing from the source tarball)

The problem is obviously, that the source tarball has no src/qt-gui/ folder.

I see that there is such a folder in this repository, but it has been stripped from the release tarball.

[x42]

That is odd. looks like you've used enable_qtgui in the past.
That setting is disabled by default, so autoreconf should not reach that code.

[umlaeute]

That is odd. looks like you've used enable_qtgui in the past.

???
this is from a fresh clone.
(also i typically build 3rd party code in throw-away containers, so ...)

That setting is disabled by default, so autoreconf should not reach that code.

note that i'm talking about autoreconf (resp. automake which is what is called under the hood).
as such, all the m4-code protecting

xjadeo/configure.ac

Line 443 in c79144b

AC_CONFIG_FILES(src/qt-gui/Makefile src/qt-gui/qjadeo.pro)

with

xjadeo/configure.ac

Line 411 in c79144b

if test "$enable_qtgui" = "yes"; then

is rather pointless - as this code is never executed (it will get executed when running ./configure; but right now we are not there yet).

but i guess that ead81da fixes it anyhow :-)

[x42]

Do you need a new release, or can you pick the fix from git?

[umlaeute]

No it's fine.
I've switched my scripts to now use the tagged archives from GitHub, rather than the source tarballs from SourceForge and reimported.