This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Avoid setting embedding view controller background color #14761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changes the
UIViewController
created when embedding aPage
on iOS to not explicitly set a background color (it was preventing embedding a transparent page).Issues Resolved
Platforms Affected
Behavioral/Visual Changes
Pages that are transparent and embedded in iOS will now appear transparent.
Testing Procedure
An option has been added to the iOS embedding test bed to display a transparent page. This also contains some semi-transparent boxes. It is shown over a yellow background that should be visible.
Additionally, other pages should be unaffected.
PR Checklist