-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve CORS issues for Visual Studio feeds #37
base: main
Are you sure you want to change the base?
Solve CORS issues for Visual Studio feeds #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the showing of the filter buttons so the CORS feeds are visible as well (remove the filter call here: https://github.com/xebia/github-copilot-updates/blob/main/src/pages/Index.jsx#L151)
@@ -10,8 +10,13 @@ | |||
"run", | |||
"dev" | |||
], | |||
"port": 3000, // Default port for Vite development server | |||
"port": 5173, // Default port for Vite development server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this port change needed at all?
const fetchRSSItems = async () => {; | ||
|
||
const fetchRSSItems = async () => { | ||
const proxyUrl = 'https://corsproxy.io/?url='; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice find. I tested it and it works. What concerns me is that they have a free plan that works for localhost requests or open source projects, but no indication how that works. They cant make the request to a localhost, and since our script runs on the users client the IP address will be different each time, so in that sense it will work, feels a bit like we are misusing their service then.
Let's merge it in for now, and I do have a plan to change this up a bit differently so we can cache the feeds in the repo instead. Let's chat on that.
This pull request includes several changes to improve the development environment and enhance the functionality of the
Index
page. The most important changes are detailed below:Development Environment Improvements:
.vscode/launch.json
: Changed the default port for the Vite development server from 3000 to 5173 and added aserverReadyAction
to debug with Edge when the server is ready.vite.config.mjs
: Enabled source maps in the build configuration to facilitate debugging.Functionality Enhancements:
src/pages/Index.jsx
: Added a proxy URL to handle CORS issues when fetching RSS items and sorted the RSS items by publication date before rendering them. [1] [2] [3]Fixes #20