Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kopff merge into dev #2828

Merged
merged 29 commits into from
Dec 18, 2024
Merged

Feature/kopff merge into dev #2828

merged 29 commits into from
Dec 18, 2024

Conversation

maurofmferrao
Copy link
Member

No description provided.

maurofmferrao and others added 27 commits August 1, 2024 09:58
relates to xibosignageltd/xibo-private#842

 - xibo-cms.js datatables moved to a new file
 - authed.twig and base.twig translations, variables and configs moved to dedicated files
  - translations and vars for editors moved to dedicated files
 - codemirror replaces heavier monaco code editor
 - old region forms removed
 - developer template page migrated
 - region and widget edit request changed to not display form
 - region and widget delete form route removed
 - file upload js is bundled
relates to xibosignage/xibo#3470

- Use isEvalSupported to prevent vulnerability
@maurofmferrao maurofmferrao self-assigned this Dec 11, 2024
dasgarner
dasgarner previously approved these changes Dec 11, 2024
Copy link
Member

@dasgarner dasgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure and commit list looks good

dasgarner
dasgarner previously approved these changes Dec 12, 2024
ifarzana
ifarzana previously approved these changes Dec 17, 2024
Copy link
Contributor

@ifarzana ifarzana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to build the container

@maurofmferrao maurofmferrao dismissed stale reviews from ifarzana and dasgarner via a56f080 December 17, 2024 15:39
@ifarzana
Copy link
Contributor

TEST: /Layout, /Schedule, /Display END

Copy link

@ifarzana
Copy link
Contributor

TEST: login.cy.js END

Copy link

@dasgarner dasgarner merged commit f7f6502 into develop Dec 18, 2024
3 checks passed
@dasgarner dasgarner deleted the feature/kopff_merge_into_dev branch December 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants