XMR: private API should be configured each time we start the container using the ENV variables #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r using the ENV variable. fixes xibosignageltd/xibo-private#901
|
@qaxlyka I do not believe it will be possible to QA test this change - running any of the automated test suite would be sufficient to prove the container still runs. |
PeterMis
approved these changes
Jan 14, 2025
|
Hi @dasgarner i dont know yet what im doing, i was just looking around to understand how it works. Might have done something I didn't mean during that time 😅 |
|
TEST: login.cy.js END |
|
Test Suite: succeeded ✅ |
|
@qaxlyka no problem, I ran an automated test which proves the container still works after my changes. That's all we need for this one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes xibosignageltd/xibo-private#901
Instead of only setting the private API configuration option on installation, we set it each time the container starts. The setting is not visible to users, so should be configured from the environment variable anyway.