Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Reporting: time connected summary report does not work with Today as the range #2856

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fixed Reporting: time connected summary report does not work with Today as the range #2856

merged 1 commit into from
Jan 17, 2025
+24 −2

Conversation

mgbaybay
Copy link
Contributor

Changes

  • Fixed data calculation for today as date range option in specific reports listed below. Previous behavior uses current datetime as the $toDt when 'today' is selected, hence, will retain this behavior instead of calculating the whole day

Reports affected:

  • API Requests
  • Display Alerts
  • Session History
  • Time Disconnected

Relates to: https://github.com/xibosignageltd/xibo-private/issues/893

@mgbaybay mgbaybay self-assigned this Jan 16, 2025
@mgbaybay mgbaybay requested a review from nadzpogi January 16, 2025 06:00
nadzpogi
nadzpogi approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@nadzpogi nadzpogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me! 😀

@maurofmferrao
Copy link
Member

TEST: login.cy.js END

@github-actions GitHub Actions
Copy link

Test Suite: succeeded ✅
https://github.com/xibosignage/xibo-cms/actions/runs/12829644375

@mgbaybay mgbaybay merged commit a757f95 into develop Jan 17, 2025
2 of 3 checks passed
@mgbaybay mgbaybay deleted the bugfix/report_filter_date_range branch January 17, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadzpogi nadzpogi nadzpogi approved these changes

Assignees

@mgbaybay mgbaybay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgbaybay @maurofmferrao @nadzpogi