National Weather Service (NWS) module for Emergency Alerts #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relates to xibosignageltd/xibo-private#902 - Modified the logic to accommodate 'No Alert' situation. - Removed the onScheduleCriteriaRequest() as this connector will share Emergency Alert's onScheduleCriteriaRequest() instead. - Code optimization. - Updated the NWS' push message's values.
relates to xibosignageltd/xibo-private#902 - Fixed PHPCS errors.
relates to xibosignageltd/xibo-private#902 - Fixed some few errors
PeterMis
approved these changes
Jan 16, 2025
We need to make sure then that we test and merge the other PR ( #2861 ) first. |
maurofmferrao
approved these changes
Jan 17, 2025
|
TEST: login.cy.js END |
|
Test Suite: succeeded ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to xibosignageltd/xibo-private#902