Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Addition v0.0.{9,10} create big cannons API does not work on Fabric, works on Forge #70

Open
1 task
onehittoaster opened this issue Dec 3, 2024 · 2 comments

Comments

@onehittoaster
Copy link

onehittoaster commented Dec 3, 2024

Mod Name

create big cannons

This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

  • I have tested this issue and it occurs with only Valkyrien Skies, addons, and the mod I have specified

Minecraft Version

1.20.1

Mod Loader

Fabric

Issue description

Placing a "CC: Tweaked" advanced computer directly in front of a properly build cannon mount (holding an auto-turret) produces different results for the peripherals command, and different available APIs between forge and fabric.

I have attempted to get the exact same versions of various mods on both Fabric and Forge, but some other mods have slightly older versions for Fabric. Details below. However, after digging through the code, I suspect that the issue is in the "VS Addition" mod. I will include screen shots if github will let me.

Basically, the full API, es expressed in [1] works in Forge, but not in Fabric.

[1] https://github.com/xiewuzhiying/VS-Addition/blob/1.20.1/main/common/src/main/kotlin/io/github/xiewuzhiying/vs_addition/compats/computercraft/peripheral/CannonMountMethods.kt

Mod Fabric Forge
CC: Tweaked 1.114.2 1.114.2
CC: C Bridge 1.6.2b-fabric 1.6.3
CC: VS 0.1.1 0.1.1
Clockwork 0.1.16 0.1.16
Create Big Cannons 5.5.1 5.6.0
Valkyrien Skies 2.3.0-beta5 2.3.0-beta5
VS Addition 0.0.10 0.0.9

Results of running peripherals on Forge (desired):

  • Peripheral Name: createbigcannons:cannon_mount.
  • Peripheral Type: cbc_cannon_mount (has desired API).

Results of running peripherals on Fabric (undesired):
(NOTE: You must run redstone set back true first to assemble the cannon on Fabric).

  • Peripheral Name: createbigcannons:cannon_mount.
  • Peripheral Type: item_storage (only has inventory API).

Forge (works):
2024-12-03_09 16 27
2024-12-03_09 17 44
2024-12-03_09 17 54

Fabric (desired API missing):
2024-12-03_09 18 47
2024-12-03_09 18 33

Issue reproduction

  1. For each mod launcher, build a minimal Create Big Cannon (I used auto-turret).
  2. Place a CC computer directly in front of the cannon mount.
  3. Run the peripherals command.
  4. Observe that the two mod loaders offer different CBC APIs. The "VS Addition" CBC API appears to be missing on Fabric.

Logs

No response

@xiewuzhiying
Copy link
Owner

This is similar to the issue super95shao mentioned to me previously, I'll look into it.

@onehittoaster onehittoaster changed the title <title>VS Addition v0.0.{9,10} create big cannons API does not work on Fabric, works on Forge VS Addition v0.0.{9,10} create big cannons API does not work on Fabric, works on Forge Dec 3, 2024
@onehittoaster
Copy link
Author

Separately, is it too much trouble to ask to add the "inventory" API as well? That can be worked around (attach a modem to a hopper to the cannon mount), but would be nice to have built-in when VS Addition is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants