Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error leaks to client: replacement transaction underpriced #409

Open
mkysel opened this issue Jan 13, 2025 · 2 comments
Open

Error leaks to client: replacement transaction underpriced #409

mkysel opened this issue Jan 13, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@mkysel
Copy link
Collaborator

mkysel commented Jan 13, 2025

When creating many MLS commits using XDBG such as cargo xdbg -b local -d generate --entity identity --amount 5, some of these might fail because of wrong pricing.

Some of these errors should not flow back to the client and should be retried by the payer.

Error: 
   0: API error: API client error: mls error: status: Internal, message: "error publishing group message: rpc error: code = Internal desc = error publishing identity update: replacement transaction underpriced", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc"} }
   1: API client error: mls error: status: Internal, message: "error publishing group message: rpc error: code = Internal desc = error publishing identity update: replacement transaction underpriced", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc"} }
   2: mls error: status: Internal, message: "error publishing group message: rpc error: code = Internal desc = error publishing identity update: replacement transaction underpriced", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc"} }
   3: status: Internal, message: "error publishing group message: rpc error: code = Internal desc = error publishing identity update: replacement transaction underpriced", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc"} }
@mkysel mkysel moved this to Todo in Decentralization Jan 13, 2025
@mkysel mkysel added the bug Something isn't working label Jan 13, 2025
@mkysel
Copy link
Collaborator Author

mkysel commented Jan 16, 2025

@fbac could I get a technical explanation of this one?

Is the fix as simple as retrying the transaction?

@fbac
Copy link
Collaborator

fbac commented Jan 17, 2025

@fbac could I get a technical explanation of this one?

Is the fix as simple as retrying the transaction?

@mkysel a transaction in the mempool (not executed) can be replaced with other with the same nonce, but has to have a higher fee, so the miner takes it over the preceding one.

Without any context, I believe what happened here is that some transaction was posted to the blockchain. Before it was executed a new one was posted, with same nonce, same gas fees, and same private key originating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants