Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excludes falsy values from request options #190

Open
sPaCeMoNk3yIam opened this issue Nov 28, 2022 · 0 comments
Open

Excludes falsy values from request options #190

sPaCeMoNk3yIam opened this issue Nov 28, 2022 · 0 comments

Comments

@sPaCeMoNk3yIam
Copy link

https://github.com/yarax/swagger-to-graphql/blob/master/src/getRequestOptions.ts#L54
A value should be allowed to be null, false or 0 and if set not throw an error.
Here the only valid check and throw should be for undefined.

https://github.com/yarax/swagger-to-graphql/blob/master/src/getRequestOptions.ts#L58
A value should be allowed to be null, false or 0 and be passed as param.
Here only undefined should not be passed.
@sPaCeMoNk3yIam sPaCeMoNk3yIam changed the title Excludes false values from request options Excludes falsy values from request options Nov 28, 2022
@sPaCeMoNk3yIam sPaCeMoNk3yIam mentioned this issue Dec 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sPaCeMoNk3yIam