Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgumentError in Rails 7.0 #75

Open
zhisme opened this issue Jan 9, 2024 · 1 comment · May be fixed by #76
Open

ArgumentError in Rails 7.0 #75

zhisme opened this issue Jan 9, 2024 · 1 comment · May be fixed by #76

Comments

@zhisme
Copy link

zhisme commented Jan 9, 2024

You are passing a block expecting two parameters,
so the old hash behavior is simulated. As this is deprecated,
this will result in an ArgumentError in Rails 7.0.
(called from full_messages at /app/vendor/ruby/3.0.0/bundler/gems/russian-630526b320f9/lib/russian/active_model_ext/custom_error_message.rb:45)
@zhisme zhisme linked a pull request Jan 11, 2024 that will close this issue
Open
@stiig
Copy link

stiig commented Mar 13, 2024

agree with that, for the next errors array

[#<ActiveModel::Error attribute=facility, type=blank, options={:message=>:required, :if=>#<Proc:0x00000001117c7998 .rvm/gems/ruby-3.2.3@mt/gems/activerecord-7.1.3.2/lib/active_record/associations/builder/belongs_to.rb:129 (lambda)>}>]

it can't handle properly because here a message is an attribute of an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rails 7.0 fix deprecation zhisme/russian
2 participants
@stiig @zhisme