diff --git a/.clang-tidy b/.clang-tidy index eb6f3b4c7b84c..8746003136a66 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -129,6 +129,7 @@ Checks: '-*, modernize-replace-auto-ptr, modernize-replace-random-shuffle, modernize-shrink-to-fit, + modernize-unary-static-assert, modernize-use-bool-literals, modernize-use-noexcept, modernize-use-nullptr, diff --git a/src/core/util/matchers.h b/src/core/util/matchers.h index ca3e55972d1b5..49b6e47fe9b5e 100644 --- a/src/core/util/matchers.h +++ b/src/core/util/matchers.h @@ -91,20 +91,15 @@ class HeaderMatcher { // the corresponding StringMatcher::Type enum values, so that it's safe to // convert by casting when delegating to StringMatcher. static_assert(static_cast(Type::kExact) == - StringMatcher::Type::kExact, - ""); + StringMatcher::Type::kExact); static_assert(static_cast(Type::kPrefix) == - StringMatcher::Type::kPrefix, - ""); + StringMatcher::Type::kPrefix); static_assert(static_cast(Type::kSuffix) == - StringMatcher::Type::kSuffix, - ""); + StringMatcher::Type::kSuffix); static_assert(static_cast(Type::kSafeRegex) == - StringMatcher::Type::kSafeRegex, - ""); + StringMatcher::Type::kSafeRegex); static_assert(static_cast(Type::kContains) == - StringMatcher::Type::kContains, - ""); + StringMatcher::Type::kContains); // Creates HeaderMatcher instance. Returns error status on failure. static absl::StatusOr Create(absl::string_view name, Type type, diff --git a/src/core/xds/xds_client/xds_client.h b/src/core/xds/xds_client/xds_client.h index 5b5fd05ab59bd..4243685e05fa5 100644 --- a/src/core/xds/xds_client/xds_client.h +++ b/src/core/xds/xds_client/xds_client.h @@ -278,18 +278,14 @@ class XdsClient : public DualRefCounted { NACKED, }; static_assert(static_cast(envoy_admin_v3_REQUESTED) == - ClientResourceStatus::REQUESTED, - ""); + ClientResourceStatus::REQUESTED); static_assert( static_cast(envoy_admin_v3_DOES_NOT_EXIST) == - ClientResourceStatus::DOES_NOT_EXIST, - ""); + ClientResourceStatus::DOES_NOT_EXIST); static_assert(static_cast(envoy_admin_v3_ACKED) == - ClientResourceStatus::ACKED, - ""); + ClientResourceStatus::ACKED); static_assert(static_cast(envoy_admin_v3_NACKED) == - ClientResourceStatus::NACKED, - ""); + ClientResourceStatus::NACKED); void AddWatcher(RefCountedPtr watcher) { watchers_.insert(std::move(watcher));