Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure timeseries data shows nulls instead of zero when data is not available #212

Open
murderteeth opened this issue Jan 29, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@murderteeth
Copy link
Collaborator

murderteeth commented Jan 29, 2025

reported from discord, https://discord.com/channels/734804446353031319/1334168008192430140

Hi people, just to let you know kong is missing some values (which seem to be populated with zeros, would rather have received NaNs and would have detected the issue more easily):


query Tvls($chainId: Int!, $address: String, $limit: Int) {
    tvls(chainId: $chainId, address: $address, limit: $limit) {
        time
        priceUsd
    }
}

This query returns zeros in priceusd.

You can test with 0x4d3ceBA4349ADB06d2De8EBD2F9320A61303aD81
but it's true for many vaults.
Would propose to keep NaNs in the db, if impossible to have a proper measurement of the price, thank you

@murderteeth murderteeth added the bug Something isn't working label Jan 29, 2025
@jorphex
Copy link

jorphex commented Feb 8, 2025

Monthly purging of tickets will delete the referenced conversation in the link above. Refer to this transcript if needed: https://tickettool.xyz/transcript/v1/1224326155717447723/1336168938962292828/transcript-closed-0627.html/67a819cb/67a6c84b/c947ffadba7231123b995645fca749faa1f580c9e2db06c5b442741b7e390630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants