Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gauge] - Improve UX around setApprovals for delegating actions #163

Open
storming0x opened this issue Jun 20, 2022 · 0 comments
Open

[Gauge] - Improve UX around setApprovals for delegating actions #163

storming0x opened this issue Jun 20, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@storming0x
Copy link
Contributor

storming0x commented Jun 20, 2022

function setApprovals(

i think it's better UX to have granular methods, instead of a single setter with boolean arguments where one argument can easily be sent in bad order and confusing for caller.

setApprovals(0x01, true, false) can have different consequences than setApprovals(0x01, false, true)

potentially error prone, i prefer explicit methods.

enableClaimingFrom(address). disableClaimingFrom(address)

enableLockingFrom(address). disableLockingFrom(address)

less arguments and makes the side effect explicit avoiding potential oops factor

@storming0x storming0x added the enhancement New feature or request label Jun 20, 2022
@storming0x storming0x changed the title Improve UX around setApprovals for delegating actions [Gauge] - Improve UX around setApprovals for delegating actions Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant