Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrategyReportResult.duration measured in milliseconds instead of days #151

Open
bsamuels453 opened this issue Feb 12, 2022 · 2 comments
Open

Comments

@bsamuels453
Copy link

StrategyReportResult.duration is supposed to be measured in days, according to its documentation. It is currently measured in milliseconds.
Either convert this field to measure the duration in days, or change the documentation to reflect its unit of measure.

Make sure upstream usages of this field in yearn-watch and yearn-sdk aren't impacted

@0xbok
Copy link

0xbok commented Mar 4, 2022

Which documentation are you referring to?

@bsamuels453
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants