Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up deploying to netlify to preview PRs #744

Closed
mischah opened this issue Oct 26, 2017 · 6 comments
Closed

Set up deploying to netlify to preview PRs #744

mischah opened this issue Oct 26, 2017 · 6 comments

Comments

@mischah
Copy link
Member

mischah commented Oct 26, 2017

Hej,

it would be awesome to setup netlify automatically deploy PRs to preview changes in the browser.

See this feature and this example.

I tried to set it up, but it seems that I’m missing Privileges:
image

Could you grant me access to set this up?

@SBoudrias
Copy link
Member

@mischah done, you're now the Yeoman site team maintainer (you can add contributors to this repo).

@mischah mischah self-assigned this Oct 27, 2017
@mischah
Copy link
Member Author

mischah commented Oct 27, 2017

@SBoudrias Thanks, seems that this isn’t enough.
I still don’t see any Yeoman repo on netlify. Guess one has to be an admin of a repo to set up netlify for it.

@mischah
Copy link
Member Author

mischah commented Oct 27, 2017

Thank @SBoudrias, I now see the repo at netlify and going to set it up 👍

@mischah mischah closed this as completed Oct 27, 2017
@mischah mischah removed their assignment Oct 27, 2017
@mischah
Copy link
Member Author

mischah commented Oct 27, 2017

It works: https://yeoman.netlify.com/ 🎉

… and should deploy pull requests as well.

@SBoudrias
Copy link
Member

Seems great! BTW there's a mixed content warning (ga script)

@mischah
Copy link
Member Author

mischah commented Oct 28, 2017

Thanks for catching that. Going to resolve that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants