Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename no-extra-spacing-attrs #204

Open
RobertAKARobin opened this issue Jul 31, 2024 · 2 comments
Open

Rename no-extra-spacing-attrs #204

RobertAKARobin opened this issue Jul 31, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@RobertAKARobin
Copy link
Contributor

#202 adds functionality that prevents extra spacing inside tags even when there are no attributes, so the -attrs in no-extra-spacing-attrs isn't quite correct.

Maybe deprecate no-extra-spacing-attrs and add a new rule called no-extra-spacing-tags, or something?

(Not sure if @yeonjuan would prefer to deprecate the current rule and add a new one, or just rename the current rule)

See #202 (comment)

@yeonjuan
Copy link
Owner

yeonjuan commented Aug 1, 2024

@RobertAKARobin Thank you for opening an issue!

Maybe deprecate no-extra-spacing-attrs and add a new rule called no-extra-spacing-tags, or something?

I think it would be better to deprecate it and add a new rule. 👍

@yeonjuan yeonjuan added the enhancement New feature or request label Aug 3, 2024
@RobertAKARobin
Copy link
Contributor Author

@yeonjuan Any particular way you want to deprecate the old rule? We could just replace all instances of "no-extra-spacing-attrs" with "no-extra-spacing-tags", but that could break things for users.

Ideally there would be a message that pops up when someone uses no-extra-spacing-attrs, e.g. "This rule has been deprecated. Please use no-extra-spacing-tags instead." Does ESLint offer something out-of-the-box for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants