Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some differences with your parameters #13

Open
Ayms opened this issue Feb 14, 2018 · 3 comments
Open

Some differences with your parameters #13

Ayms opened this issue Feb 14, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@Ayms
Copy link

Ayms commented Feb 14, 2018

Please see https://bitcointalk.org/index.php?topic=2827163.msg30284004#msg30284004

And https://github.com/Ayms/bitcoin-transactions

@ymgve
Copy link
Owner

ymgve commented Feb 14, 2018

What differences are you specifically talking about?

@Ayms
Copy link
Author

Ayms commented Feb 14, 2018

I did not compare everything but for example we have different protocol versions for UBTC, BTN and BTSQ, see https://github.com/Ayms/bitcoin-transactions/blob/master/tx.js#L75-L432 similar to your https://github.com/ymgve/bitcoin_fork_claimer/blob/master/claimer.py#L617-L874

@ymgve
Copy link
Owner

ymgve commented Feb 14, 2018

Ah, right. I haven't really kept up/looked up protocol version numbers for most coins as it seems to work with my default.

@ymgve ymgve added the enhancement New feature or request label Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants