Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

我看内部有 带timeout 的pub函数,为什么没有对外暴露呢? #12

Open
qingfeng777 opened this issue Jul 16, 2019 · 2 comments

Comments

@qingfeng777
Copy link

内部带timeout 的 pub函数,好像只是用了 config里的timeout,没有在对外暴露的 Publish函数里提供timeout 参数。这是为什么呢,有什么考虑吗?

`

producer.go line 1671

func (self *TopicProducerMgr) doCommandWithRetry(topic string, partitionKey []byte,
commandFunc CmdFuncT) ([]byte, error) {
return self.doCommandWithTimeoutAndRetry(topic, partitionKey, 0, 3, commandFunc)
}
`

@qingfeng777
Copy link
Author

为什么不加一个 带有timeout参数的 publish函数

@absolute8511
Copy link
Contributor

目前是通过config配置全局控制pub timeout的, 可以考虑加一个

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants