Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is clean_str present in wikienv? #31

Open
jamesbraza opened this issue Aug 26, 2024 · 1 comment
Open

Why is clean_str present in wikienv? #31

jamesbraza opened this issue Aug 26, 2024 · 1 comment

Comments

@jamesbraza
Copy link

I am finding certain strings can break clean_str:

p = "This is a test string with unicode escape: \\u00e9"

This will break clean_str:

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe9 in position 43: unexpected end of data

Why do we need to convert string to be UTF-8? And if it's required, why not just ignore conversion errors?

@jamesbraza jamesbraza changed the title Why is clean_str present in the repo? Why is clean_str present in wikienv? Aug 26, 2024
@ysymyth
Copy link
Owner

ysymyth commented Jan 16, 2025

does it actually break things when you run? if so happy to accept pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants