Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable maximum request body in worker #28

Open
jenschelkopf opened this issue Nov 8, 2016 · 3 comments
Open

Allow configurable maximum request body in worker #28

jenschelkopf opened this issue Nov 8, 2016 · 3 comments

Comments

@jenschelkopf
Copy link

It will likely be a common use case for remotedev-server to handle large request bodies since redux trees can get large for complex applications.

By default remotedev-server will support request bodies of up to 100kb, which is pretty small as far as redux state goes. Requests larger than that size will receive a 413 response from the server.

Please add a configuration option for the maximum request body. Configurable is good so users can limit exposure to the security risk of large request bodies to an amount appropriate for their operational environment.

Here's a good example of setting the limit in the bodyParser middleware: http://stackoverflow.com/a/19965089/194957

@zalmoxisus zalmoxisus mentioned this issue Nov 9, 2016
Merged
10 tasks
zalmoxisus added a commit that referenced this issue Nov 9, 2016
@zalmoxisus
Copy link
Owner

zalmoxisus commented Nov 9, 2016

We also need this to be implemented for sockets, but it's hardcoded to 16mb for now.

@Ricardo-C-Oliveira
Copy link

This would a huge improvement! My application has to load a full GeoJSON file into memory, which is 24mb but will likely get 10 times bigger. Because of this I'm unable to to use the remote redux tool to debug the app :(.

@zalmoxisus
Copy link
Owner

@Ricardo-C-Oliveira, not sure how fast the serialization will be in such cases, it could freeze the browser for several seconds-minutes. Better to strip unnecessary data using actionSanitizer /stateSanitizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants