Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamPumper threads are not interrupted when main thread is interrupted #60

Open
ghilainm opened this issue May 29, 2018 · 1 comment

Comments

@ghilainm
Copy link

StreamPumper threads are not interrupted when main thread is interrupted.

This piece of code seems to miss an outputThread.interrupt().

if (outputThread != null) { log.trace("Joining output thread {}...", outputThread); try { outputThread.join(); outputThread = null; } catch (InterruptedException e) { // ignore } }

This cause threads to be blocked until the process dies. Or it is necessary to call several time interrupt with some delay in order to really cause the thread to be interrupted.

@nemecec
Copy link
Collaborator

nemecec commented Feb 22, 2023

Would you be willing to send a pull request?
(Sorry for the long delay, I'm taking over maintenance of this project so communication should be faster from now on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants