You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In a thread-controlled environment, it could be great to provide our own ExecutorService instance in order to keep control over the thread pool instead of automatically instantiating a new newSingleThreadScheduledExecutor everytime we want to execute a command.
In the class ProcessExecutor, what do you think if we could have the possibility to do the following:
public StartedProcess start(ExecutorService providedService) throws IOException {
WaitForProcess task = startInternal();
ExecutorService service;
if (providedService == null) {
service = newExecutor(task);
} else {
service = providedService;
}
Future<ProcessResult> future = invokeSubmit(service, task);
This is not an issue but for us it appears as a limitation of the ProcessExecutor class.
The text was updated successfully, but these errors were encountered:
Would you be willing to send a pull request?
(Sorry for the long delay, I'm taking over maintenance of this project so communication should be faster from now on)
In a thread-controlled environment, it could be great to provide our own ExecutorService instance in order to keep control over the thread pool instead of automatically instantiating a new
newSingleThreadScheduledExecutor
everytime we want to execute a command.In the class
ProcessExecutor
, what do you think if we could have the possibility to do the following:This is not an issue but for us it appears as a limitation of the
ProcessExecutor
class.The text was updated successfully, but these errors were encountered: