Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more than 20 reactions per event #65

Open
Gehock opened this issue Mar 27, 2021 · 5 comments · May be fixed by #86
Open

Add support for more than 20 reactions per event #65

Gehock opened this issue Mar 27, 2021 · 5 comments · May be fixed by #86
Labels
enhancement New feature or request priority: low

Comments

@Gehock
Copy link
Member

Gehock commented Mar 27, 2021

The discord API only allows 20 reactions in a single message. This limit gets often exceeded because of multiple additional roles. The easiest solution would most likely to create a separate message for the extra reactions.

The challenge is that currently the code relies very heavily on the fact that a singe Event == single message and vice versa.

@Gehock Gehock added enhancement New feature or request priority: high labels Mar 27, 2021
@MaxKosi MaxKosi assigned MaxKosi and unassigned MaxKosi Mar 28, 2021
@MaxKosi
Copy link
Collaborator

MaxKosi commented May 4, 2021

image
4Ai6DS5
because I always forget what we discussed
https://discord.com/channels/219564389462704130/530411066585382912/825741913738969108

@MaxKosi
Copy link
Collaborator

MaxKosi commented May 4, 2021

Current structure (if im correct):

Event holds List of roleGroups which contains roles
when creating an event it goes through that list and adds them to the embed
Currently hard coded is an role limit of 20 for that event.
There is currently also a limit of 20 additional roles because of the saved emotes in the config file

TODO:
event.py

  1. remove the limiter in addAdditionalRole()

Functions to touch:
commandListener.py
_update_event
messageFunctions.py
createEventMessage
updateMessageEmbed
event.py
__init__
createEmbed
countReactions ?
toJson
fromJson

return embeds as a list
issue: message.id

@MaxKosi
Copy link
Collaborator

MaxKosi commented May 5, 2021

Suggestion: Divide this Issue in multiple smaller issues.

Right now solving this issue is very complicated because, as already said, the code heavily relies that it works with one message.
So far I came to following solution:
createEmbed in event.py returns a list of embeds
Issue: Identification of messages in relation to the event.
Solution: Create list of messageID in event.py
Issue: Methods rely on getting one messageID and not a list

@Gehock help

@Gehock
Copy link
Member Author

Gehock commented May 10, 2021

Creating a list of embeds and storing a list of messageIDs sounds reasonable to me. One thing that would cause some extra work might be sorting messages, right now sorting relies quite heavily on the fact that a single event has a single message. Not considering sorting, I think that dealing with multiple messageIDs might not be too complicated.

@MaxKosi MaxKosi linked a pull request May 26, 2021 that will close this issue
@Gehock
Copy link
Member Author

Gehock commented Feb 6, 2023

With the current player numbers, this is not really a high priority anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants