How to override "identify" action in Quirks

[Ben3094]

Hello,
I just found the correct way to trigger identification mechanism in my Legrand button. So, I would to know if you can customize the "identify" action in a Quirk.
Thank you in advance

[TheJulianJES]

You'd need to override the "identify" command on the "Identify" cluster. Similar to this, but for identify:

zha-device-handlers/zhaquirks/xiaomi/aqara/roller_curtain_e1.py

Lines 83 to 106 in de3643c

	class WindowCoveringRollerE1(CustomCluster, WindowCovering):
	"""Window covering cluster to receive commands that are sent to the AnalogOutput's present_value to move the motor."""
	async def command(
	self,
	command_id: foundation.GeneralCommand | int | t.uint8_t,
	*args: Any,
	manufacturer: int | t.uint16_t | None = None,
	expect_reply: bool = True,
	tsn: int | t.uint8_t | None = None,
	**kwargs: Any,
	) -> Any:
	"""Overwrite the commands to make it work for both firmware 1425 and 1427.
	We either overwrite analog_output's current_value or multistate_output's current
	value to make the roller work.
	"""
	if command_id == WindowCovering.ServerCommandDefs.up_open.id:
	(res,) = await self.endpoint.multistate_output.write_attributes(
	{"present_value": 1}
	)
	return foundation.GENERAL_COMMANDS[
	foundation.GeneralCommand.Default_Response
	].schema(command_id=command_id, status=res[0].status)

[Ben3094]

Hi @TheJulianJES,

I tried but failed again... ^^'

from typing import Any
from zigpy.quirks.v2 import CustomCluster, QuirkBuilder
import zigpy.types as t
from zigpy.zcl.foundation import GeneralCommand
from zhaquirks.legrand import LEGRAND
from zigpy.zcl.clusters.general import Identify, EffectIdentifier, EffectVariant

MODEL = " Dimmer switch w/o neutral"

class CustomIdentify(CustomCluster, Identify):
	async def command(self,
		command_id: GeneralCommand | int | t.uint8_t,
		*args: Any,
		manufacturer: int | t.uint16_t | None = None,
		expect_reply: bool = True,
		tsn: int | t.uint8_t | None = None,
		**kwargs: Any) -> Any:
		return await super().command(
			Identify.ServerCommandDefs.trigger_effect.id,
			effect_id = EffectIdentifier.Blink,
			effect_variant = EffectVariant.Default
		)

(
	QuirkBuilder(LEGRAND, MODEL)
	.replaces(CustomIdentify)
	.add_to_registry()
)

The command is close to the correct one but malformed...
The correct one:

Sending CommandId.aps_data_request{'request_id': 63, 'flags': <DeconzSendDataFlags.NONE: 0>, 'dst': DeconzAddressEndpoint(address_mode=<AddressMode.NWK: X>, address=0xXXXX, endpoint=1), 'profile_id': 260, 'cluster_id': 3, 'src_ep': 1, 'asdu': b'\x01\x07@\x00\x00', 'tx_options': <DeconzTransmitOptions.USE_NWK_KEY_SECURITY: 2>, 'radius': 0, 'relays': None} (seq=239)

The one I send:

Sending CommandId.aps_data_request{'request_id': 38, 'flags': <DeconzSendDataFlags.NONE: 0>, 'dst': DeconzAddressEndpoint(address_mode=<AddressMode.NWK: X>, address=0xXXXX, endpoint=1), 'profile_id': 260, 'cluster_id': 3, 'src_ep': 1, 'asdu': b'\x01\x04\x00\x05\x00', 'tx_options': <DeconzTransmitOptions.USE_NWK_KEY_SECURITY: 2>, 'radius': 0, 'relays': None} (seq=161)

Can you help me again ?...

I am so sorry 🙏
Thank you in advance,
Best regards,
Ben